grt: append nodes and edges from removed nets when merging nets#7650
Merged
eder-matheus merged 8 commits intoJun 25, 2025
Conversation
…preserved net Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
maliberty
approved these changes
Jun 24, 2025
Member
Author
|
@maliberty FYI, I'll hold the merge of this PR until I have a complete secure-ci. It didn't went through due to the sta issue. |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
…ges/nodes Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
This was referenced Jun 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When merging the routing of two nets after buffer removal, the FastRouteCore data regarding edges and nodes of the deleted net was just being deleted, but the congestion information of them wasn't updated. This caused multiple congestion issues during post-GRT incremental repair, since the congestion data of these edges was never updated.
Solution
Instead of just deleting the edges and nodes of the deleted nets, append them to the edges and nodes of the preserved net (i.e., the net that will "receive" the routing of the deleted net). This way, the congestion data can be properly updated in future iterations of the global routing tool.